search

movio / bramble

A federated GraphQL API gateway
https://movio.github.io/bramble/
MIT License
497 stars 55 forks source link

Remove query caching from exposed gateway #131

Closed LeonHuston closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #131 (0cf7bfd) into main (13268f2) will increase coverage by 0.14%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   69.51%   69.65%   +0.14%     
==========================================
  Files          24       24              
  Lines        2624     2633       +9     
==========================================
+ Hits         1824     1834      +10     
+ Misses        669      668       -1     
  Partials      131      131
Impacted Files Coverage Δ
gateway.go 67.74% <100.00%> (+13.19%) :arrow_up:
auth.go 87.42% <0.00%> (+0.62%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13268f2...0cf7bfd. Read the comment docs.

lucianjon commented 2 years ago

LGTM, could you just mention that you removed this too: 

    srv.Use(extension.AutomaticPersistedQuery{
        Cache: lru.New(100),
    })