search

movio / bramble

A federated GraphQL API gateway
https://movio.github.io/bramble/
MIT License
497 stars 55 forks source link

Improve "not currently supported" part of README.md #137

Closed pasdeloup closed 2 years ago

pasdeloup commented 2 years ago

Following Issue #136 , I just propose a quick README update to make it more explicit that unions can't be shared across services + a link to the FAQ to provide more details.

lucianjon commented 2 years ago

Good idea, thanks @pasdeloup. Just to be exhaustive, could you please add there's also no support for shared scalars and enums? There is discussion around this in https://github.com/movio/bramble/issues/10.

codecov-commenter commented 2 years ago

Codecov Report

Merging #137 (f54d5f0) into main (70a8e42) will increase coverage by 0.03%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   69.58%   69.61%   +0.03%     
==========================================
  Files          24       24              
  Lines        2630     2630              
==========================================
+ Hits         1830     1831       +1     
+ Misses        669      668       -1     
  Partials      131      131
Impacted Files Coverage Δ
auth.go 87.42% <0.00%> (+0.62%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 70a8e42...f54d5f0. Read the comment docs.

lucianjon commented 2 years ago

Thanks @pasdeloup