search

movio / bramble

A federated GraphQL API gateway
https://movio.github.io/bramble/
MIT License
497 stars 55 forks source link

Increase default polling period to 10 seconds. #143

Closed lucianjon closed 2 years ago

lucianjon commented 2 years ago

This is to get around a race condition with nodejs based servers who have a default HTTP Keep-Alive of 5 seconds.

codecov-commenter commented 2 years ago

Codecov Report

Merging #143 (041ac0d) into main (c074105) will increase coverage by 0.03%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   70.36%   70.40%   +0.03%     
==========================================
  Files          24       24              
  Lines        2602     2602              
==========================================
+ Hits         1831     1832       +1     
+ Misses        651      650       -1     
  Partials      120      120
Impacted Files Coverage Δ
config.go 6.81% <0.00%> (ø)
auth.go 87.42% <0.00%> (+0.62%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c074105...041ac0d. Read the comment docs.

lucianjon commented 2 years ago

If we still see issues with the defaults of other servers will have to introduce some kind of random jitter or a very obscure time.