search

movio / bramble

A federated GraphQL API gateway
https://movio.github.io/bramble/
MIT License
497 stars 55 forks source link

Correctly include subtypes of union in filtered schema. #145

Closed lucianjon closed 2 years ago

lucianjon commented 2 years ago

When filtering down a schema union sub types could get incorrectly excluded from the final schema.

This occurs when the permissions do not specify AllowAll on the union type but rather use field level permissions.

codecov-commenter commented 2 years ago

Codecov Report

Merging #145 (7836775) into main (03264a7) will increase coverage by 0.13%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   70.49%   70.62%   +0.13%     
==========================================
  Files          24       24              
  Lines        2613     2611       -2     
==========================================
+ Hits         1842     1844       +2     
+ Misses        651      649       -2     
+ Partials      120      118       -2
Impacted Files Coverage Δ
auth.go 89.17% <100.00%> (+2.37%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03264a7...7836775. Read the comment docs.