movio / bramble

A federated GraphQL API gateway
https://movio.github.io/bramble/
MIT License
497 stars 55 forks source link

Use the default cloudflare recommended timeouts #162

Closed pkqk closed 2 years ago

pkqk commented 2 years ago

Use the cloudflare recommended default timeouts for http.Server as recommended by @aerfio in #161

This might be worth being configurable, especially if used in combination with the max-response-time of the limits plugin.

codecov-commenter commented 2 years ago

Codecov Report

Merging #162 (a139fda) into main (24b50dc) will decrease coverage by 0.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   70.62%   70.58%   -0.05%     
==========================================
  Files          25       25              
  Lines        2676     2679       +3     
==========================================
+ Hits         1890     1891       +1     
- Misses        666      668       +2     
  Partials      120      120              
Impacted Files Coverage Δ
cmd/bramble/main.go 0.00% <0.00%> (ø)
auth.go 89.17% <0.00%> (+0.63%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 24b50dc...a139fda. Read the comment docs.