search

movio / bramble

A federated GraphQL API gateway
https://movio.github.io/bramble/
MIT License
497 stars 55 forks source link

Populate PossibleTypes with merged type #165

Closed pkqk closed 2 years ago

pkqk commented 2 years ago

The mergePossibleTypes function when populating the types just used the value from one of the source trees instead of the merged type.

This would only be apparent once one type of an interface was a @boundary type, depending on the order the services were merged in the final merged schema could be missing fields from other services.

codecov-commenter commented 2 years ago

Codecov Report

Merging #165 (8223454) into main (7dbaf67) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   70.54%   70.58%   +0.03%     
==========================================
  Files          25       25              
  Lines        2679     2679              
==========================================
+ Hits         1890     1891       +1     
+ Misses        669      668       -1     
  Partials      120      120
Impacted Files Coverage Δ
merge.go 93.54% <100.00%> (ø)
auth.go 89.17% <0.00%> (+0.63%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7dbaf67...8223454. Read the comment docs.