movio / bramble

A federated GraphQL API gateway
https://movio.github.io/bramble/
MIT License
497 stars 55 forks source link

Pass variables downstream #167

Closed mai00cmi closed 1 year ago

mai00cmi commented 2 years ago

Instead of inlining variables into downstream queries, which failed when the serialisation of the value from json didn't match the graphql syntax (eg if the variable was a complex json type) filter the variables map to the values required by the downstream query.

This should enable the definition of things like a json scalar value without bramble interfering and generating a syntactically invalid query.

codecov-commenter commented 2 years ago

Codecov Report

Base: 70.80% // Head: 70.80% // No change to project coverage :thumbsup:

Coverage data is based on head (cf2f07f) compared to base (cf2f07f). Patch has no changes to coverable lines.

:exclamation: Current head cf2f07f differs from pull request most recent head 61039fc. Consider uploading reports for the commit 61039fc to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #167 +/- ## ======================================= Coverage 70.80% 70.80% ======================================= Files 26 26 Lines 2699 2699 ======================================= Hits 1911 1911 Misses 665 665 Partials 123 123 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.