movio / bramble

A federated GraphQL API gateway
https://movio.github.io/bramble/
MIT License
497 stars 55 forks source link

Propogate `operationName` to subqueries #174

Closed andyyu2004 closed 1 year ago

andyyu2004 commented 1 year ago

This is useful for tracing and metrics. Currently child queries are made with an empty operationName.

codecov-commenter commented 1 year ago

Codecov Report

Base: 70.76% // Head: 70.81% // Increases project coverage by +0.05% :tada:

Coverage data is based on head (a46d015) compared to base (2b601fd). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #174 +/- ## ========================================== + Coverage 70.76% 70.81% +0.05% ========================================== Files 26 26 Lines 2692 2697 +5 ========================================== + Hits 1905 1910 +5 Misses 664 664 Partials 123 123 ``` | [Impacted Files](https://codecov.io/gh/movio/bramble/pull/174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio) | Coverage Δ | | |---|---|---| | [client.go](https://codecov.io/gh/movio/bramble/pull/174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio#diff-Y2xpZW50Lmdv) | `82.08% <100.00%> (+0.55%)` | :arrow_up: | | [executable\_schema.go](https://codecov.io/gh/movio/bramble/pull/174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio#diff-ZXhlY3V0YWJsZV9zY2hlbWEuZ28=) | `77.72% <100.00%> (ø)` | | | [execution.go](https://codecov.io/gh/movio/bramble/pull/174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio#diff-ZXhlY3V0aW9uLmdv) | `83.43% <100.00%> (+0.15%)` | :arrow_up: | | [introspection.go](https://codecov.io/gh/movio/bramble/pull/174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio#diff-aW50cm9zcGVjdGlvbi5nbw==) | `80.64% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.