movio / bramble

A federated GraphQL API gateway
https://movio.github.io/bramble/
MIT License
497 stars 53 forks source link

Split error update metrics into gauge and counter #211

Closed pkqk closed 1 year ago

pkqk commented 1 year ago

Use counter for tracking number of failures and the gauge for current error states.

We were finding once the error state was triggered it could not be reset as the counter is intended to be used as an ever incrementing metric.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.05 :warning:

Comparison is base (4aed5b6) 70.92% compared to head (dba646d) 70.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #211 +/- ## ========================================== - Coverage 70.92% 70.88% -0.05% ========================================== Files 26 26 Lines 2721 2724 +3 ========================================== + Hits 1930 1931 +1 - Misses 668 670 +2 Partials 123 123 ``` | [Impacted Files](https://app.codecov.io/gh/movio/bramble/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio) | Coverage Δ | | |---|---|---| | [metrics.go](https://app.codecov.io/gh/movio/bramble/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio#diff-bWV0cmljcy5nbw==) | `0.00% <0.00%> (ø)` | | | [executable\_schema.go](https://app.codecov.io/gh/movio/bramble/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio#diff-ZXhlY3V0YWJsZV9zY2hlbWEuZ28=) | `77.39% <100.00%> (+0.10%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/movio/bramble/pull/211/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.