movio / bramble

A federated GraphQL API gateway
https://movio.github.io/bramble/
MIT License
497 stars 53 forks source link

Add a counter metric for service timeouts #221

Closed pkqk closed 1 year ago

pkqk commented 1 year ago

This will provide a metric for knowing if downstream services are hitting the time limit (if set by the limits plugin) for a request.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.03% :warning:

Comparison is base (87f96c5) 71.06% compared to head (c4592e5) 71.04%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #221 +/- ## ========================================== - Coverage 71.06% 71.04% -0.03% ========================================== Files 27 27 Lines 2737 2742 +5 ========================================== + Hits 1945 1948 +3 - Misses 670 672 +2 Partials 122 122 ``` | [Files Changed](https://app.codecov.io/gh/movio/bramble/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio) | Coverage Δ | | |---|---|---| | [metrics.go](https://app.codecov.io/gh/movio/bramble/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio#diff-bWV0cmljcy5nbw==) | `0.00% <0.00%> (ø)` | | | [client.go](https://app.codecov.io/gh/movio/bramble/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio#diff-Y2xpZW50Lmdv) | `83.56% <100.00%> (+0.95%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/movio/bramble/pull/221/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.