movio / bramble

A federated GraphQL API gateway
https://movio.github.io/bramble/
MIT License
497 stars 55 forks source link

Don't exit on misconfigured plugins #225

Closed andyyu2004 closed 1 year ago

andyyu2004 commented 1 year ago

I don't think a misconfigured plugin should not prevent bramble from starting up. The handling should be analogous to the case where the plugin is unregistered, warn and move on.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.07% :warning:

Comparison is base (bc2b4a8) 71.07% compared to head (afb3d26) 71.01%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #225 +/- ## ========================================== - Coverage 71.07% 71.01% -0.07% ========================================== Files 27 27 Lines 2742 2743 +1 ========================================== - Hits 1949 1948 -1 - Misses 671 673 +2 Partials 122 122 ``` | [Files Changed](https://app.codecov.io/gh/movio/bramble/pull/225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio) | Coverage Δ | | |---|---|---| | [config.go](https://app.codecov.io/gh/movio/bramble/pull/225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio#diff-Y29uZmlnLmdv) | `6.76% <0.00%> (-0.06%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/movio/bramble/pull/225/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=movio)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.