Closed pkqk closed 7 months ago
Attention: 23 lines
in your changes are missing coverage. Please review.
Comparison is base (
3c1b58b
) 71.07% compared to head (71a4e80
) 72.24%.
Files | Patch % | Lines |
---|---|---|
config.go | 41.02% | 14 Missing and 9 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Going to check during the day and will let you know.
Thanks already for the fast response!
This works perfectly for me. 👍 Can be merged!
These timeouts should be tuneable for users who don't want to limit downstream services to only accept fast responses.
Address #228 by providing the option to increase the write timeout.
@codedge can you give this a review and see if it addresses your issue, it wasn't able to be configured by the
limits
plugin as it's themain
method that sets up thehttp.Server
instances.In the
config.json
you can either provide adefault-timeouts
map ofread
,write
andidle
keys that will be used for all thehttp.Server
instances or override the defaults withgateway-timeouts
andprivate-timeouts
maps that only need to provide values differing from the defaults.