Continuing_connection - Githubissues

mowblox / emt-marketplace

The goal is to help people become really good at what they do through decentralized mentorship.

https://emt-marketplace.vercel.app

Apache License 2.0

1 stars 3 forks source link

Continuing_connection #28

Closed Jovells closed 10 months ago

vercel[bot] commented 10 months ago

@Jovells is attempting to deploy a commit to the Mowblox Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
emt-marketplace	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 26, 2023 1:04am

od41 commented 10 months ago

Hi @Jovells,

There are a few issues I noticed with the loading states, empty states of some views.

i.e

in the All posts view it shows "Done"; I'll create an empty posts component for when there are no posts to display also, another LoadingData component that fits the container when data is loading.
Profile: when a user isn't signed in and they visit a profile link it should show a non-signed in view for that profile.
Notifications: should redirect them to the home page, should also hide the non-auth navigation links(I'll handle this)
All posts: you should be able to view posts without signing in
View a post: I created a post and wasn't able to view it, it just kept spinning and loading.

Recording this for the next PR, I think this works and we can improve on it. I also wanted to start working on the bits that are UI related right now.

Jovells commented 10 months ago

Well noted.

Is intentional. to give feedback about the Infinite scroll state in the interim. Should be replaced with some kind of loading ui when loading and hidden when done
noted
wip
Currently you can, but not in the "Following" tab because you aren't signed. What shows now is just interim feedback until ui for that state is available. Probably the following tab should not even show when not signed in.
I'll investigate that

od41 commented 10 months ago

@jovells

a. I understand the 'Done' when loading is complete. b. i'm not sure how to implement the infinite scroll loading. Use a "load more" button to trigger or fire an event when you scroll to the bottom?
I agree that the Following tab should be hidden when not signed in.

Jovells commented 10 months ago

@od41

The logic has already been implemented. isFetchtingNextPage becomes true when posts are being fetched (when the button of the page is reached and there are more posts to fetch). So you can have a loading component show up at the bottom of the page in that state
Okay