search

mowispace / react-native-logs

Performance-aware simple logger for React-Native and Expo with namespaces, custom levels and custom transports (colored console, file writing, etc.)
MIT License
467 stars 33 forks source link

Potentially redundant .then()? #21

Closed chmac closed 3 years ago

chmac commented 3 years ago

Saw this:

https://github.com/onubo/react-native-logs/blob/913eb01ac550970b659528ae04a80080bce85b4c/src/transports/rnFsFileAsync.ts#L45

I think the .then() is redundant? Or maybe it serves some purpose that's not immediately obvious to me?

alessandro-bottamedi commented 3 years ago

Yes I must have left it by mistake, I'll remove it in the next commit thanks