mowispace / react-native-logs

Performance-aware simple logger for React-Native and Expo with namespaces, custom levels and custom transports (colored console, file writing, etc.)
MIT License
467 stars 33 forks source link

Would it make sense to remove dist from git? #23

Closed chmac closed 3 years ago

chmac commented 3 years ago

Would it make sense to remove the built javascript dist folder from git? I'm used to TypeScript packages that only check the src folder into git. Maybe there's something I'm missing here?

alessandro-bottamedi commented 3 years ago

Usually I don't include the dist folder either, but leaving it there is convenient for me to publish the package on npm

chmac commented 3 years ago

@alessandro-bottamedi Gotcha. Is there a risk that dist gets out of date from src that way? That is usually my concern with the approach. I tend to put build and publish scripts into package.json so that I'm consistent, otherwise I always end up forgetting parts of the process.

alessandro-bottamedi commented 3 years ago

@chmac You're right, in fact I have inserted in package.json this little script: "precommit": "rm -rf dist && tsc && jest --verbose" but there is the risk of forgetting to run it.

Maybe in the next version I will consider whether to delete dist folder

alessandro-bottamedi commented 3 years ago

Fixed in v 3.0.0