search

moxie-lean / Lean

Bare bones WordPress starter theme focused on modularity, scalability and performance.
http://getmoxied.net/
GNU General Public License v2.0
19 stars 4 forks source link

Basic style #50

Closed mitogh closed 8 years ago

mitogh commented 8 years ago

@nucro do you have any feedback from the comments above?

https://github.com/moxie-leean/Leean/pull/50

Thanks.

orcunilbeyli commented 8 years ago

@mitogh Yeah I am still working on that. I was busy with other tasks that Wissam assigned to me yesterday. And started to switch BEM today. Created a sample html in latest commits. Jeremy made some feedbacks. I am going to fix them tomorrow.

mitogh commented 8 years ago

No problem just to make sure we are on the same page, because I didn't see any previous comment from you on this PR. If you leave comments here it's better rather to have visibility rather than email because we can keep the historically track of each comment on in each line of code as well.

orcunilbeyli commented 8 years ago

Okay will be extra careful about this. Thanks.

orcunilbeyli commented 8 years ago

Fixed all feedbacks that Jeremy addressed. After you approve html sample about BEM changes, I'll implement this to whole project and jump to style issues that Cris mentioned. @jrrrsmith @mitogh

mitogh commented 8 years ago

Hey @nucro I'm going to open some issues, please make sure to address them one you have a change also let me know if yo have any question about my comments on each issue.