search

moxie-lean / Lean

Bare bones WordPress starter theme focused on modularity, scalability and performance.
http://getmoxied.net/
GNU General Public License v2.0
19 stars 4 forks source link

Content hover should have a transition #60

Closed mitogh closed 8 years ago

mitogh commented 8 years ago

Take a look at the other elements like the button for example of the comment, those hover states has a transition before change of color, in my personal opinion this will make things more smoothly.

Let me know if you have any question about this.

Thanks.

orcunilbeyli commented 8 years ago

We can use transition for buttons but imho, anchor links should not have transition. What do you think? @mitogh

mitogh commented 8 years ago

Transitions between colours, take a look at the original link style of the Leen theme there was a transition on color change of each link. @nucro

orcunilbeyli commented 8 years ago

Yeah I know. I removed them because it didn't look well on colors. I can put them back if you want. I am just explaining my humble opinion. I am talking about anchor link transitions btw.

mitogh commented 8 years ago

Ok I think this is what we are going to do.

  1. Create 1 extra class something like: content--transitions or anything you feel is better.
  2. All links inside of this container are going to have transitions.
  3. We add or remove this class on the content container in order to have both behaviours and decide on future any one.

Let me know if that makes sense to you.

orcunilbeyli commented 8 years ago

Okay. On it. Thanks.

jrrrsmith commented 8 years ago

@nucro looks good, and yes please reference the issue in your commit so we can find the changes faster, that would be a big help. Good job. Closing.