moxie0 / Convergence

An agile, distributed, and secure alternative to the Certificate Authority system.
http://convergence.io
623 stars 127 forks source link

Firefox extension: missing small icons toolbar layout #116

Open altblue opened 12 years ago

altblue commented 12 years ago

Using Firefox v7.0.1 with Convergence v0.07, noticed that when placed on a toolbar that uses small icons, Convergence's button breaks that compact layout.

A quick workaround is to plug a CSS rule like:

toolbar[iconsize="small"] #convergence-button {height: 16px !important}
moxie0 commented 12 years ago

If you have an idea for a fix, a git pull request would be sweet.

fgb commented 12 years ago

Wouldn't just a smaller icon fix this? In my case, its default location (on the url toolbar) works well even when "Use small icons" is set. It looks like the icon is a bit big for the button, but it doesn't break the UI.

However, when I move the button to the tab bar, the icon size breaks the layout, oddly superimposing the current tab to the url toolbar (this is with tabs on top on Aurora 13.0a2. I can downgrade and check on Firefox 11 if it helps).

Edit: I'm running Firefox on OSX 10.6.8

fgb commented 12 years ago

On a related note, I'm not too stoked about the icon chosen for the button. I'd rather it be a smaller version of /client/icon.png, without the padlock or the colors (maybe by graying it out when disabled?). This would make it easier for it to be included within the url field (much like the bookmarking star).

It would also be great to have a sub-menu in Tools/ so as to not depend on the button.