search

moxie0 / Convergence

An agile, distributed, and secure alternative to the Certificate Authority system.
http://convergence.io
623 stars 127 forks source link

Adding notary from URL doesn't work #171

Open r-st opened 11 years ago

r-st commented 11 years ago

Steps to reproduce:

  1. In Convergence preferences click to Add Notary.
  2. Fill the remote .notary URL.
  3. Click OK.

Expected result: New notary is added.

Actual result: Nothing happens.

Versions: Firefox 19.0.2 and 20.0 Convergence 0.09 vanilla and patched with patch from #170.

mk-fg commented 11 years ago

For me the problem was in invalid number of arguments passed to nsIWebBrowserPersist.saveURI in client/chrome/content/util/ConvergenceUtil.js. Can be fixed by simply passing null as the last argument (since we only care about the contents there).

I've pushed this one fix to fix_adding_notaries_from_url branch - you might want to try running that, but not sure if it's an upstreamable solution as it'll probably break older FF versions (which worked with originial call).

r-st commented 11 years ago

Now it works, thanks.

mk-fg commented 11 years ago

Was probably a bit unclear (sorry) in "pushed this one fix to ... branch" - that branch is in my fork, so I think it's still a valid issue in this repo, thus might be worth keeping it open (i.e. reopening) in case someone else stumbles upon it and/or @moxie0 (or whatever valid comitters) find time to look at it here.

r-st commented 11 years ago

OK, reopening :-)