search

moxie0 / Convergence

An agile, distributed, and secure alternative to the Certificate Authority system.
http://convergence.io
621 stars 108 forks source link

Verification status text fixed #59

Closed cless closed 13 years ago

cless commented 13 years ago

Verification mouseover status now correctly shows the status of a 303 reply as "Verification Inconclusive" instead of "Connectivity Failure".

chrisglass commented 13 years ago

Nice :)

chrisglass commented 13 years ago

Just gave it a spin - works perfectly.

cless commented 13 years ago

@chrisglass Thanks for verifying the code!

moxie0 commented 13 years ago

Thanks for doing this. I'm curious what the motivation for reordering is. Why not just have the 303 case return -2, add a case in the stringify on the chrome side, and have that be it?

cless commented 13 years ago

edited this reply after thinking through my reasoning again

@moxie0, I choose to reorder the status codes because it would make calculating the consensus a lot easier. Before reordering all status codes seemed to be placed at random regardless of their meaning. The way it's ordered now all the status codes below 0 mean failure (connection fail, verification fail). 0-2 means the vote is ignored (relay, 303, connection failure) and lastly 3 means verification success. In hindsight maybe it was better if I used 0 for verification correct, < 0 for fail and > 0 for ignore. I can change that still if that makes more sense.

moxie0 commented 13 years ago

@cless Thanks, I think I agree that < 0 fail, 0 success, >0 ignore would make more sense.

cless commented 13 years ago

Well I royally screwed that up, kindly ignore while I try to fix this. Sorry!

Edit: there we go, that should do it.