moxie0 / Convergence

An agile, distributed, and secure alternative to the Certificate Authority system.
http://convergence.io
623 stars 127 forks source link

dependency on python-twisted-names + default/convergence #83

Closed pesco closed 12 years ago

pesco commented 12 years ago

a) python-twisted-names seems to be required by GoogleCatalogVerifier:

% sudo /etc/init.d/convergence start
Raising maximum number of filedescriptors (ulimit -n) to 32768.
Starting convergence notary: convergence...
Traceback (most recent call last):
  File "/usr/local/bin/convergence-notary", line 49, in <module>
    from convergence.verifier.GoogleCatalogVerifier import GoogleCatalogVerifier
  File "/usr/local/lib/python2.6/dist-packages/convergence/verifier/GoogleCatalogVerifier.py", line 19, in <module>
    import twisted.names.client
ImportError: No module named names.client

b) i don't know if setup.py should do something smart with the default file, but overwriting a customized one on every update doesn't look right. ;)

pesco commented 12 years ago

oh, where did all those extra commits come from. it doesn't seem to matter. sorry, i'm still getting used to github. :(

moxie0 commented 12 years ago

Thanks for this. I didn't know what was going on with this pull request (also new to github), so I just made the twisted-names changes directly in 85c03425e8449f9ac30f798cd4a0d2acbca9d22e. Do you want to figure out how to do something clever (install but don't overwrite) with the defaults file and open a new pull request?

ewanm89 commented 12 years ago

I think it does all the commits in branch since the split from the other one minus any already applied, this is why one of my requests cause it was branched off another persons tree and that hadn't been pulled by moxie yet had all his requests too.

pesco commented 12 years ago

Do you want to figure out how to do something clever (install but don't overwrite) with the defaults file and open a new pull request?

i'll give it a try.

pesco commented 12 years ago

actually, it appears i was mistaken and Python distutils already does what we want: it doesn't overwrite the file if it already exists. so there is nothing to do. sorry for the confusion! ;)