search

moxiecode / moxie

Pollyfills for XHR2 and File API
GNU Affero General Public License v3.0
483 stars 134 forks source link

Memory leak in IE #157

Closed hicham-barhoumi closed 8 years ago

hicham-barhoumi commented 8 years ago

When you destroy a HTML5Image object in IE OR Edge the image object stay on memory and not get collected by the garbage collector. ex : var _img = new image(); _img.load = function(){ ... } _img.src = '...'; _img = null;

This is blocking issue when you deal with lot of images with high quality.

jayarjo commented 8 years ago

If you create a pull request, I will merge this in.

jayarjo commented 8 years ago

Merged it myself here: https://github.com/moxiecode/moxie/commit/f51cea4328623c87f960b8e3314d39a6916e867b. Thanks!

jayarjo commented 8 years ago

Oh crap. Took author from that repo on your account and turns out it wasn't even yours. Nah...

You should have filed pull request there. Now your contribution is authored by some random guy :/

Sorry.

hicham-barhoumi commented 8 years ago

You shouldn’t merged it was closed :)