moxis / cryptosight.io

Former issue tracker for CryptoSight. Now just a repository to host the photo gallery website.
http://cryptosight.io
0 stars 0 forks source link

Users and Timeframe - Possible bug #9

Open Diavolo3045 opened 6 years ago

Diavolo3045 commented 6 years ago

As time frame moves its interval, if user trades are older than 1 day or outside of the time frame, if you realize a sell in the time frame, then the bot do not verifies the old buy then yielding pure profit (money out of thin air). I've an example case that has been forwarded through telegram.

moxis commented 6 years ago

@Dante2333 Please show me the example. There should be a function implemented that's supposed to prevent this

Diavolo3045 commented 6 years ago

Dante, [14.10.17 17:35] i believe i can reproduce the bug

Dante, [14.10.17 17:46] [Forwarded from Dante] 💰 Profit

Dante, [14.10.17 17:46] [Forwarded from CryptoSight] Working on it...

Dante, [14.10.17 17:46] [Forwarded from CryptoSight] You have profited 0.10289074 BTC (22.3%)! That is about 589.57 USD.

Dante, [14.10.17 17:46] [Forwarded from Dante] 💵 Pair Profit

Dante, [14.10.17 17:46] [Forwarded from CryptoSight] Please choose a pair (eg. ETH or BTC_ETH):

Dante, [14.10.17 17:46] [Forwarded from Dante] ARk

Dante, [14.10.17 17:46] [Forwarded from CryptoSight] Working on it...

Dante, [14.10.17 17:46] [Forwarded from CryptoSight] You have profited 0.00243553 BTC trading BTC to ARK! That is about 13.98 USD.

Dante, [14.10.17 17:47] the second one is the reality (0.00243553) but ifi change the timeframe to a position where the original buy never happened, then the first example happens, it considers it as pure profit.

moxis commented 6 years ago

Should be fixed in the last update. Reopen if it keeps occurring.

moxis commented 6 years ago

Nah still broken :(