Closed ritazoliveira closed 4 years ago
Merging #92 into master will not change coverage by
%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #92 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 33 33
Lines 42 42
Branches 1 1
=========================================
Hits 42 42
Impacted Files | Coverage Δ | |
---|---|---|
packages/eslint-config-base/lib/modules/esm.js | 100.00% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 235f9b3...aa19ad4. Read the comment docs.
@ritazoliveira I would also consider enabling https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/newline-after-import.md.
Removed the mandatory new line after each import group and also added the newline-after-import
rule.
This is a breaking change. @ritazoliveira next time don’t forget to sinal it in the commit message or body.
Fixed the commit to include BREAKING CHANGE
in the body.
In light of this RFC two rules were added to our config:
import/order
: displays an error when imports are not in the following order:builtin
,external
,parent
,sibling
,index
and groups are not separated with a new line.import/first
: displays an error when imports are made in the module's body.As for
import/first
, since we already happen to haveimport/order
, which already orders the module's import, this could be turned off in certain cases but maybe it's best to ensure all imports are made at the top of the file.