chore(cookies): fix plural wording

[threequartersjohn]

Changes all instances of cookieConsents and CookieConsents to cookiesConsent and CookiesConsent, respectively, where the change in wording is meant to express "The user provides consent for cookies".

This is because consent is an uncountable noun in this context. Consents is a valid word, but only when the consent in question relates to e.g. documents or otherwise numerable items that individually express some consent, which is not the case here.

[codecov[bot]]

Codecov Report

Merging #116 (98adee6) into master (7fbd99e) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #116   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          115       115           
  Branches        11        11           
=========================================
  Hits           115       115           

Impacted Files	Coverage Δ
www/app/App.js	100.00% <100.00%> (ø)
...shared/modules/react-cookie-banner/CookieBanner.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7fbd99e...98adee6. Read the comment docs.

[satazor]

The module currently only has one consent, which is analytics, but is prepared to allow for other use cases as well. Therefore there are multiple consents.

Having that said, shouldn’t we be using plural as it’s a collection of consent?

[satazor]

Note that cookies is just the way the consents are stored, we could be using local storage instead. I believe the name CookieBanner is a classic name, based on old cookies policy, but now is broader, as recent privacy regulations must ask specifically for granular consents. In a site where multiple granular consents must be given, this banner would have a checkbox for eacc consent.

[threequartersjohn]

Note that cookies is just the way the consents are stored, we could be using local storage instead. I believe the name CookieBanner is a classic name, based on old cookies policy, but now is broader, as recent privacy regulations must ask specifically for granular consents. In a site where multiple granular consents must be given, this banner would have a checkbox for eacc consent.

Hmm, i understand. I'm ok with closing this PR if you don't think there is anything further to say on this.

[satazor]

👍