moxystudio / next-with-moxy

MOXY's boilerplate to accelerate the setup of new Next.js based web applications
https://next-with.moxy.tech
MIT License
101 stars 11 forks source link

Use new syntax to set environment variables in CI #117

Closed acostalima closed 3 years ago

acostalima commented 3 years ago

The workflow which deploys to Vercel is currently failing:

Screenshot 2021-01-14 at 13 09 08

The set-env command was deprecated a few months ago and recently disabled. This PR updates the workflow to use the new syntax.

github-actions[bot] commented 3 years ago

This pull-request can be previewed at https://next-with-moxy-pr-117.vercel.app. Please check the Vercel status below to see when it's ready.

codecov[bot] commented 3 years ago

Codecov Report

Merging #117 (17964d5) into master (7d9cfc8) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #117   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          115       115           
  Branches        11        11           
=========================================
  Hits           115       115           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d9cfc8...17964d5. Read the comment docs.

acostalima commented 3 years ago

Now it's failing due to lack of permissions. 😕 @satazor, do you have any clue what's going on?

satazor commented 3 years ago

@acostalima I don't think the env variable is passing trough the vercel cli call, as the CI is failing saying we don't have access.

acostalima commented 3 years ago

@satazor I've just echoed SITE_URL in the failing step and the variable is indeed defined. Even when inlining https://next-with-moxy-pr-117.vercel.app, it fails.

satazor commented 3 years ago

Fixed it!