moxystudio / next-with-moxy

MOXY's boilerplate to accelerate the setup of new Next.js based web applications
https://next-with.moxy.tech
MIT License
101 stars 11 forks source link

refactor: custom medias to have more breakpoints #47

Closed nlfonseca closed 4 years ago

nlfonseca commented 4 years ago

⚠️ Merge after #46

custom-medias have now more breakpoints.

Besides, this is a new typology, since we are in 2020 and we don't know anymore what is the difference between a tablet and a phone width, I think that we need to be more agnostic. What do you think about this?

see www/shared/styles/imports/custom-medias.css

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/moxystudio/next-with-moxy/8jh3c7jdn ✅ Preview: https://next-with-moxy-git-refactor-custom-media.moxystudio.now.sh

codecov[bot] commented 4 years ago

Codecov Report

Merging #47 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #47   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines          32     32           
  Branches        5      5           
=====================================
  Hits           32     32

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a070cee...467f6a3. Read the comment docs.