moxystudio / next-with-moxy

MOXY's boilerplate to accelerate the setup of new Next.js based web applications

https://next-with.moxy.tech

MIT License

101 stars 11 forks source link

fix: rerender with intl test #54

Closed threequartersjohn closed 4 years ago

threequartersjohn commented 4 years ago

Fixes rerenderWithIntl test. Missed this during code review, so here's the PR with the fix.

As it was, this test was not testing whether rerenderWithIntl was wrapping the intl provider, because no child would require it.

With a FormattedMessage child, this test now actually tests if rerenderWithIntl wraps its children with the necessary provider and does not throw any errors.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/moxystudio/next-with-moxy/72804yehr ✅ Preview: https://next-with-moxy-git-fix-render-with-intl-test.moxystudio.now.sh

satazor commented 4 years ago

Looks good.

codecov[bot] commented 4 years ago

Codecov Report

Merging #54 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #54   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines          32     32           
  Branches        5      5           
=====================================
  Hits           32     32

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 997d600...6544bcf. Read the comment docs.