search

moxystudio / next-with-moxy

MOXY's boilerplate to accelerate the setup of new Next.js based web applications
https://next-with.moxy.tech
MIT License
101 stars 11 forks source link

docs: recipe on how to setup different favicons depending on the OS theme #62

Closed jdiogopeixoto closed 4 years ago

jdiogopeixoto commented 4 years ago

This PR adds a new recipe on how to setup different favicons depending on the OS theme.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/moxystudio/next-with-moxy/fmcy7ru8z ✅ Preview: https://next-with-moxy-git-docs-recipe-favicons-light-dark-mode.moxystudio.now.sh

satazor commented 4 years ago

@jdiogopeixoto I've made a few improvements. Please check my last commit or simply check the end-result.

satazor commented 4 years ago

Also please test if the code snippet on the App.js file is working correctly as I added new metatags, wrapped in fragments.

jdiogopeixoto commented 4 years ago

@satazor Looks good to me! Just deleted duplicate text and also tested the snippet, it works fine. Ready to go! 🚀

satazor commented 4 years ago

Merged!