PedroMiguelSS commented 4 years ago

This PR:

renames components folder to modules
renames each component folder inside modules to have react- prefix e.g. shared/components/cookie-banner -> shared/modules/react-cookie-banner
adds a new component inside /www/pages/contacts to show how to handle non-shared components (/pages/contacts/modules/react-project-info)

This PR replaces #85 .

Due to some related imports being performed from different locations (context and corresponding hooks, .e.g) a new folder is created to aggregate all that is react. The discussion can be found in the following link: https://moxystudio.slack.com/archives/CGS7BHZM0/p1585155018032800

github-actions[bot] commented 4 years ago

This pull-request can be previewed at https://next-with-moxy-pr-88.now.sh. Please check the Zeit Now status below to see when it's ready.

codecov[bot] commented 4 years ago

Codecov Report

Merging #88 into master will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #88   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        15    +1     
  Lines           75        78    +3     
  Branches         9         9           
=========================================
+ Hits            75        78    +3

Impacted Files	Coverage Δ
www/app/App.js	`100.00% <ø> (ø)`
www/pages/contacts/Contacts.js	`100.00% <ø> (ø)`
...shared/modules/react-cookie-banner/CookieBanner.js	`100.00% <ø> (ø)`
www/shared/modules/react-footer/Footer.js	`100.00% <ø> (ø)`
www/shared/modules/react-header/Header.js	`100.00% <ø> (ø)`
www/shared/modules/react-main-layout/MainLayout.js	`100.00% <ø> (ø)`
...hared/test-utils/modules/react-app-tree/AppTree.js	`100.00% <ø> (ø)`
www/pages/contacts/project-info/ProjectInfo.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 944a5ce...9906444. Read the comment docs.

ruimonteiro93 commented 4 years ago

LGTM.

dominguesgm commented 4 years ago

LGTM 👍

paulobmarcos commented 4 years ago

Todo: update next-with-moxy conventions to match the new structure.

Give good examples :+1:

moxystudio / next-with-moxy

chore: rename components folders to modules #88

Codecov Report