search

moxystudio / webpack-isomorphic-compiler-reporter

Beautiful reporting for webpack-isomorphic-compiler compilation events
MIT License
7 stars 1 forks source link

fix: remove `humanErrors` because it was too opiniated #17

Closed satazor closed 6 years ago

satazor commented 6 years ago

The current humanErrors check is actually very limited and too opiniated. Later on, we could create a specific module that checks the config in a more generic and complete way, e.g.: webpack-isomorphic-compiler-checker.

This commit could be considered to contain a breaking change, but since it's an option that does something "extra" without side-effects, I'm passing it as non-breaking.

See #15

codecov[bot] commented 6 years ago

Codecov Report

Merging #17 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #17   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      3    -1     
  Lines          56     25   -31     
  Branches        8      0    -8     
=====================================
- Hits           56     25   -31
Impacted Files Coverage Δ
index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 599c78e...0bff497. Read the comment docs.

andrefgneves commented 6 years ago

LGTM 👍