search

moxystudio / webpack-isomorphic-compiler-reporter

Beautiful reporting for webpack-isomorphic-compiler compilation events
MIT License
7 stars 1 forks source link

Warn of human errors before any compilation event #6

Closed andrefgneves closed 6 years ago

andrefgneves commented 6 years ago

Should we report human errors before the compilation events start, like I proposed in #5? If so, and for consistency, we should also update webpack-isomorphic-dev-middleware to do the same.

satazor commented 6 years ago

webpack-isomorphic-dev-middleware may only check for human errors after a compilation because it checks the assets which are only available after compiling.

Should we change this to end instead? If we do that, we must also do the same for the error event and remove both listeners when the check is done.

I don't know if it's necessary to make things complex for such minimal benefit.

andrefgneves commented 6 years ago

Yes, I agree it's not worth it. Closing.