Fix up construct-2.9 dependencies

moyix / pdbparse

Python code to parse Microsoft PDB files

Other

309 stars 83 forks source link

Fix up construct-2.9 dependencies #47

Closed ikelos closed 5 years ago

ikelos commented 5 years ago

Sorry, messed up the setup.py dependencies. 5:S Hopefully won't be too many other bits that haven't been exercised since the changes, but happy to fix them up (as long as you're happy with merge requests for them)... 5:)

moyix commented 5 years ago

Yup, definitely happy to merge other things you find!

ikelos commented 5 years ago

Cool, I'll just keep putting any changes I find here and then when it calms down we can push it (mebbe next week sometime?). 5:) Thanks!

ikelos commented 5 years ago

Spotted an issue when I converted String to PaddedString. It's still present in IMAGE_SECTION_HEADER.Name, but I think that will always work out as utf8 rather than utf16 as was used in the GUID conversion. Probably worth merging at this point (since it does break parsing of certain PDBs depending on their GUID) and then I can do another pull request if anything else major crops up. 5:)

moyix commented 5 years ago

Cool, I'll pull these in :) Thanks again for the updates!