ZSH + HomeBrew (- some checks) = simpler updater!

mozamimy / chromium-updater

A bash script to ease upgrades of the Chromium web browser on OS X

27 stars 11 forks source link

ZSH + HomeBrew (- some checks) = simpler updater! #13

Open dardo82 opened 9 years ago

dardo82 commented 9 years ago

I have done this, try it and tell me what would you change: http://gist.github.com/dardo82/9e815aa00ab4c361e60c

mozamimy commented 9 years ago

I checked your code, and there are some points to be improved.

It seems to work under only zsh, but this project aims to support also bash.
I cannot agree that this script is dependent on the homebrew.

Because the Macports still have deep-rooted popularity and also bash. Moreover, bash is default shell on OS X. I want to make this script more general.

So I have no choice but to accept your suggestion :confounded:

P.S. In my opinion, I like Homebrew and bash.

ghost commented 9 years ago

Hi again :)

I created a version of getchromium that uses brew only if it's installed. Take a look at it, at greensn0w/chromium-updater:integrate-homebrew

mozamimy commented 9 years ago

Its good :+1:

ghost commented 9 years ago

ok I'll create a PR

dardo82 commented 9 years ago

OK, i have made it for my own use, so never minds if you don't like it. Anyhow homebrew and zsh are quite popular even if not the defaults. I have posted it here as it is the fittest place, not hoping for a merge...

mozamimy commented 9 years ago

@dardo82 Your suggestion brings new awareness to this project. Thank you for your contribution by the comment! And your script is very simple and cool i think :blush:

dardo82 commented 9 years ago

Maybe it is too simple... But that suits my tastes. It's based on your script, so thanks for making it...