Set headers - Githubissues

mozart-analytics / sqsd

A simple alternative to the Amazon SQS Daemon ("sqsd") used on AWS Beanstalk worker tier instances.

MIT License

59 stars 8 forks source link

Set headers #5

Closed tkleinhakisa closed 8 years ago

tkleinhakisa commented 9 years ago

Added headers to the request sent to the workers

according to http://docs.aws.amazon.com/elasticbeanstalk/latest/dg/using-features-managing-env-tiers.html

[x] User-Agent
[x] X-Aws-Sqsd-Msgid
[x] X-Aws-Sqsd-Queue
[x] X-Aws-Sqsd-First-Received-At // TODO: convert timestamp to ISO 8601
[x] X-Aws-Sqsd-Receive-Count
[x] Content-Type
[ ] X-Aws-Sqsd-Taskname
[ ] X-Aws-Sqsd-Attr
[ ] X-Aws-Sqsd-Scheduled-At
[ ] X-Aws-Sqsd-Sender-Id

As my java skills are limited i would be very thankfull if anyone could help me finish the list

Thanks you

abdielou commented 9 years ago

Good stuff. I can see the usefulness of X-Aws-Sqsd-Attr-*.... but in the end it's up to the app to decide what's useful and what's not. That being said I guess we should just include them all only if they exists. By all I mean, they whole list and any custom attribute (X-Aws-Sqsd-Attr-*).

mortizbey commented 8 years ago

@abdielou what do you recommend here? Is it "mergeable" already?

abdielou commented 8 years ago

@ortimanu not really. Check my last message. We run the risk of sending empty properties. We should only send those specified. We can either dump a headers object from the request or iterate and add those we care about.

jadbox commented 8 years ago

Msgid is a must for me to at least add that.

abdielou commented 8 years ago

@tkleinhakisa and @jadbox : had to modify the changes suggested originally here to only send headers included in the request. Take a look at #11