Made redundant by brick-dialog?

mozbrick / brick-action-menu

It's an action menu for Brick!

Apache License 2.0

0 stars 2 forks source link

Made redundant by brick-dialog? #1

Open lmorchard opened 10 years ago

lmorchard commented 10 years ago

So, I started building this for brick issue #207 before I saw mozbrick/brick-dialog.

But, now that I do see that component... Is this standalone action menu redundant?

ATTN: @dotch @potch @nicola

lmorchard commented 10 years ago

Or, are there any features of this that could get turned into a PR on brick-dialog? Only thing I can think of is maybe the callback on show() that returns which button was clicked. This is a pretty feature-lite element

potch commented 10 years ago

I think <brick-dialog> is pretty general, and there are things from brick-action-menu that can definitely be incorporated. Maybe it's worth having an action-menu component that can be placed in the brick-dialog? That would meet our goal of composability vs redundancy.

nicola commented 10 years ago

Hi @lmorchard, I think we were working on that in the same days. I went through your code and I think there are very great bits to merge (e.g. the animation handling, the 'pick' event), we should have a quick chat soon

lmorchard commented 10 years ago

Notes from triage meeting:

Merge any useful parts for animation & style into <brick-dialog>
Reduce this component down to a wrapper for a set of buttons, with event delegation to emit the single pick event

That way, <brick-dialog> can handle all the display stuff and this component can do just the pick thing well.