fix for transition-type = none

mozbrick / brick-deck

A Brick box element in which cards can be cycled independently of order with a variety of different transitions.

Apache License 2.0

2 stars 4 forks source link

fix for transition-type = none #14

Closed obama closed 3 years ago

obama commented 10 years ago

when transition-type = none is set, cards are not hidden properly. for once there was only tested if the attribute 'transition-type' is set, but but not if its 'none'. in that case the transitionend event will never fire, resulting in that the attributes hide, transition, transition-direction are not removed, and displaying several cards at once.

obama commented 10 years ago

well, the type 'none' is not part of the specification (as i see now) but the demo actually uses type 'none' which breaks it.. so dunno

dotch commented 10 years ago

thanks for the fix! thinking about this, I would rather get rid of transition-type=none altogether and remove it from the examples. @potch what do you think?