French translations (work in progress)

mozdevs / html5-games-workshop

HTML5 games workshop: build a platformer game!

https://mozdevs.github.io/html5-games-workshop/

Creative Commons Attribution Share Alike 4.0 International

48 stars 27 forks source link

French translations (work in progress) #19

Open greut opened 7 years ago

greut commented 7 years ago

This is a work in progress PR. Any feedbacks, comments, help are welcome.

delapuente commented 7 years ago

I would separate this PR into two: one with the infrastructure for the new language, and other for the translations.

greut commented 7 years ago

@delapuente what would you consider being the infrastructure? I could easily split it off.

belen-albeza commented 7 years ago

Hi @greut thanks for your initiative in translating this to French. Merci beaucoup!

Please note the following:

Do not add a permalink / collection if that set has not been translated yet.
It'd be good if you could separate 1PR per document/guide translated. For instance, the setup guide (which consists of two markdown documents or "steps" would be a PR, the whole platform another one, etc.)
I'd rather avoid to have a translation of a guide that is not completed. For instance, it's OK if only the coaching guide is translated, but I'm reluctant to merge a guide that only some of the steps are in the target language (it could create false expectations in people).

Again, thanks a lot!

greut commented 7 years ago

@belen-albeza I'm currently building it as part of some teaching I'm doing. I'll split the work into more finelly grained PR for each guide then, once ready.

This PR make this translation effort visible, I've changed to title to reflect that.

De nada! I'm the one thanking you.

belen-albeza commented 7 years ago

Please could you not change Phaser's version? 2.7.x corresponds to the community edition and I have not tested the code there. 2.6.2 is the latest one supported officially, and I believe it's more reliable to use that for the tutorial until Phaser 3 is released.

Thanks!

greut commented 7 years ago

@belen-albeza duly noted. It seemed to fire less warnings and it's a commit that can be ditched as required.