search

mozes / smpp.twisted

SMPP 3.4 client built on Twisted
Other
46 stars 29 forks source link

Do not send enquirelinks when session is not bound yet #2

Closed farirat closed 12 years ago

farirat commented 13 years ago

Old behaviour: The client sends enquirelinks to the server when the session state is not bound, this can be reproduced by simulating a server which delays bind_resp response, in the meanwhile, the client sends enquirelinks and the server will not respond since the client is not authentified "yet".

This can cause a lot of timeouted outbound exceptions.

theduderog commented 12 years ago

Fourat, thank you very much for the patch. It wasn't quite this simple. The enquire link timer has to be enabled once the bind is successful or else is doesn't get started until a message is send or received. I've checked in changes and unit tests with this functionality.