search

mozfreddyb / webext-firstpartyisolation

Enable First Party Isolation Pref
Mozilla Public License 2.0
55 stars 4 forks source link

[bug report] functionality conflict with other WX #10

Closed ghost closed 5 years ago

ghost commented 5 years ago

Suppose this is independent of OS (version) but it should be mentioned that this is reported from a W10 x64 v1809 b17763.55 and FF 65.0a1 (2018-10-25) (64-bit) and v1.3.1 of this WX

mozfreddyb commented 5 years ago

Thank you for trying my extension. It does works for me on Nightly. So, please help me understand what exactly isn't working for you. Can you provide a detailed explanation containing three items: 1) Steps To Repeat, 2) What you expected to happen and 3) What actually happened

Otherwise, I will have to close this issue as invalid.

ghost commented 5 years ago

I would expect clicking ther WX's icon in order to disable/enable FPI the value of privacy.firstparty.isolate being toggled accordingly (false/true). But that is not happening.

fip disabled

mozfreddyb commented 5 years ago

This is odd. I can't reproduce on Firefox Nightly 65.0a1 (2018-10-25) (64-bit).

What I'm doing: 1) go to about:config, search for isolate 2) Click the fishbowl 3) Turns orange and pref gets set to false. 4) Click again 4) Turns grey and pref gets set to true again.

Can you try again with all of your other extensions disabled? The button "Restart with add-ons disabled" in about:support is useful here

ghost commented 5 years ago

What I'm doing:

Same this end but different outcome.

all of your other extensions disabled? The button "Restart with add-ons disabled" in about:support is useful here

It is not really, because it restarts the browser in safe mode and prevents, like any other WX, from being enabled.

So probably a conflict with (an)other WX(s) then. Thus far discovered the settings of the below stated WX taking precedence (toggling their FPI settings toggles also privacy.firstparty.isolate) over this WX.

Disabling those WX returns the functionality of this WX.

On the other hand toggling manually the value of privacy.firstparty.isolate in about:config does not change the status (icon colour) of this WX either.

mozfreddyb commented 5 years ago

I don't understand why you have many extensions providing the same functionality. If you have another extension enforcing the pref to be set, we can't do our thing reliably.

So far we're intentionally not listening to the onChange event for this preference for two reasons: 1) the event wasn't supported in Firefox when I first wrote the extension 2) as it is not exposed to the user by default. My thinking is that if someone wants to modify it on their own, we shouldn't get in the way.

However, I do agree that we could listen to onChange to change the look of the web extensions icon. Would you agree with my thinking? Is there anything else actionable coming out of this bug, in your opinion?

If not, I'd lean towards closing this as a "bug report" and have new work continue in issue #11 (which btw, is up for grabs if you're interested in playing with the code of this extension)

ghost commented 5 years ago

I don't understand why you have many extensions providing the same functionality.

This WX been used to toggle FPI quickly if needed and to indicate the current status of FPI, as it only serves/focuses on FPI. Other WX have extended functionality beyond FPI but FPI cannot be toggled with a single click on the WX icon and lacking a status indicator of the FPI status.

If you have another extension enforcing the pref to be set, we can't do our thing reliably.

I am not a coder and a have no clue how Mozialla has designed/implemented WX to interact with each other in terms of seizing control of a config setting, i.e. whether only a single WX can be in control of a config exclusively and how the order of control is established. I would have assumed that WX are treated equally and a config setting changed via one WX is reflected in the settings of the other WX (and vice versa).

My understanding now is that this WX assumes to be the sole WX in control of FPI and is currently not checking/reading/reflecting the actual status of privacy.firstparty.isolate.

It would be good if this WX would not ony reflect the actual status of FPI (icon colour) but somehow also be able to change the FPI status even if another WX is offering the same option.

I'd lean towards closing this as a "bug report"

You are the developer and thus at liberty. I just reported the issue encountered. For the time being I have disabled this WX for the apparent reason.

mozfreddyb commented 5 years ago

My understanding now is that this WX assumes to be the sole WX in control of FPI and is currently not checking/reading/reflecting the actual status of privacy.firstparty.isolate.

Yes. I will fix that in #11.

It would be good if this WX would not ony reflect the actual status of FPI (icon colour) but somehow also be able to change the FPI status even if another WX is offering the same option.

With FPI enabled, the button will continue to work as a toggle. With one caveat: But if another web extension monitors for changes of the pref and re-enables it, then this extensions won't be able to overpower the misbehaving extension. At that point, you'll have to decide.