search

mozfreddyb / webext-firstpartyisolation

Enable First Party Isolation Pref
Mozilla Public License 2.0
55 stars 4 forks source link

Need a test for the user to make sure the addon is working #3

Closed woctezuma closed 6 years ago

woctezuma commented 6 years ago

I see two reviews on Mozilla Add-Ons. Both point out that the user has no way to make sure the addon is working as advertised. There has to be a test to let the user ensure it is working.

mozfreddyb commented 6 years ago

Oh yes, an FPI test page would be a great idea! I'll add this to my todo list, albeit with a relatively low priority. I'm happy to provide hosting & sketch out a development plan if someone's willing to take this on!

mozfreddyb commented 6 years ago

https://mozfreddyb.github.io/test-firstpartyisolation/ should work.

Would be great if someone would test and report bugs they find, before I close his issue here. cc @edouard-lopez

woctezuma commented 6 years ago

I cannot say much, because:

blank tab

It must be my addons which mess with the webpage. The result is that I cannot say whether Firefox fails or succeeds at that test.

mozfreddyb commented 6 years ago

The test must fail in IE, that's expected. But the popup tab should be closed automatically...interesting. Do you see any interesting log output in the developer tools (CTRL+SHIFT+K) in either the test page or the opened popup?

woctezuma commented 6 years ago

For the test page, nothing.

For the opened popup, which opens in a new tab for me, I get two warnings:

popup

There is also a message written on a yellow background regarding missing ressources when trying to access the html document by clicking on the security error.

link

As I said, I'm using a bunch of addons, so it might be just me.

mozfreddyb commented 6 years ago

I've tested on IE11 and Edge, which should show the correct result. So does Chromium. I've tested Epiphany as a WebKit browser, for a lack of an actual Safari, but it keeps showing up as FPI enabled, which seems odd. Need to investigate further.

mozfreddyb commented 6 years ago

Hm, Firefox Nightly broke some things. Should work again. Safari/Epiphany still show as "FPI Enabled", which is odd.

woctezuma commented 6 years ago

The test is processed fine by my Firefox now.

pass

I'm not using your addon, but it seems to work. Maybe, it is Multi-Account Container.

mozfreddyb commented 6 years ago

Could also be Cookie AutoDelete, the test is a bit brittle if you use other privacy-enhancing addons.

mozfreddyb commented 6 years ago

I'm thinking of closing this with a patch that points to the test, but I'd be glad if more people tested this before I do so.

stoically commented 6 years ago

When deactivating Third-party cookies in the Firefox Preferences the FPI test also reports success.

mozfreddyb commented 6 years ago

Yes, I think I could fix this (null with third party cookies disabled, unequal with FPI).

Hard to make a clear judgement if both.

Can you report this in the repo for the test?

stoically commented 6 years ago

Fixing that sounds good!

Sorry, I'm not exactly sure what you mean. Report what and where?

mozfreddyb commented 6 years ago

Closing this with a pointer to the issue at the other repository above -----^.