Is the feature enable?

[edouard-lopez]

Env

58.0b5 (64-bit)

Problem

I'm quoting some review as I met the same issue:

To echo an earlier review (with better grammar), which mirrored my thought perfectly well: I can't tell if it's enabled or disabled. Clicking its fishbowl icon doesn't visibly change its state; there seems to be no way of knowing if it is working.

Fix the state notification and then we can review whether it's working as intended... when we actually know it's supposed to be working.

A simple sentence on the button would help:

• FPI enable, click to disable
• FPI disable, click to enable

[mozfreddyb]

Yes, thank you for raising this here. Which version of Firefox are you using?

[edouard-lopez]

@mozfreddyb updated

[mozfreddyb]

I'm not sure I understand. Were/Are you using Firefox 57 or something newer?

[edouard-lopez]

I'm using 58.0b5 (64-bit), I updated the initial description

[mozfreddyb]

Hm, so some background here: The add-on enables FPI and the icon is grey by default. It turns orange when you click (and if FPI is disabled). The hover text is "Click to disable" (since enable is default) and "Click to re-enable". This sucks if enabling failed once though. Mh. But I can't think of a scenario in Firefox >58 where the add-on wouldn't be able to set the pref.

[edouard-lopez]

Your user interface should tell user what is it's current state:

• feature is disabled, disable the button (grey)
• feature is enabled, enable the button (color)

For example, checkout you wifi icon on android:

[mozfreddyb]

Yeah, it usually does that, though with different colors. The grey I use is taken from all other icons, so the add-on does not stand out too much. It should be orange when disabled.

I'll investigate some more.

[mozfreddyb]

Should be fixed. Please file a new issue if your problem persists.