search

mozilla-ai / lm-buddy

Your buddy in the (L)LM space.
Apache License 2.0
64 stars 3 forks source link

Update Ray job submission example in README #118

Closed dpoulopoulos closed 3 weeks ago

dpoulopoulos commented 1 month ago

Commit 0975fb2 changes the CLI groups finetune and evaluate, but the Ray job submission example in the README file still uses the deprecated run command.

What's changing

Update the example to match the new API.

How to test it

Run the example script on a Ray cluster.

veekaybee commented 3 weeks ago

Will merge this on top of this PR merge, needed to pin a few dependencies https://github.com/mozilla-ai/lm-buddy/pull/119

veekaybee commented 3 weeks ago

Related version update: https://github.com/mozilla-ai/lm-buddy/pull/120

veekaybee commented 3 weeks ago

@dpoulopoulos Since we made a change in requirements here to satisfy failing tests, if you could also add a version bump in your PR in pyproject.toml so we can satisfy the semver check, this should be good to merge!

dpoulopoulos commented 3 weeks ago

@veekaybee I added a semver bump commit on top and rebased the whole branch on top of main so you can do a fast forward merge. I'm not sure if it makes sense to make it 0.14.0 or 0.13.1. Let me know if this is okay.

veekaybee commented 3 weeks ago

Perfect, thanks!