mozilla-ai / lumigator

Source code for Mozilla.ai's Lumigator platform
https://mozilla-ai.github.io/lumigator/
Apache License 2.0
63 stars 7 forks source link

Separating out setting model type into a separate method in the job service #385

Closed veekaybee closed 2 days ago

veekaybee commented 4 days ago

What's changing

We currently have a lot going on in the create_job method which makes it hard to unit test granularly. We've previously done some work in pulling out separate methods (see https://github.com/mozilla-ai/lumigator/pull/328), this PR does the same for _set_model_type and adds tests also clarifying the model URL (it wouldn't be S3 since we use either huggingface, openai or mistral at the moment) in the SDK.

How to test it

Run unit tests

Additional notes for reviewers

I already...

cc @peteski22 @javiermtorres fyi for SDK changes

veekaybee commented 4 days ago

Also adding ruff precommit hooks here because they're not getting caught before they reach the linter in CI