search

mozilla-extensions / aboutsync

A Firefox addon to show information about Sync.
Mozilla Public License 2.0
73 stars 17 forks source link

Include validator version in anonymized exports #21

Open ghost opened 7 years ago

ghost commented 7 years ago

I just saw a screenshot of an export where the mobile root shows up under "records appear on the server but should not have been uploaded". IIUC, Thom fixed that in https://bugzilla.mozilla.org/show_bug.cgi?id=1309774, so now I'm wondering if that's from an older version of the validator, or if something else is going on.

Including the validator version in the export, like we do for the ping, would help figure this out.

Validator screenshot

mhammond commented 7 years ago

👍

mhammond commented 7 years ago

Thinking some more about this, I'm not sure it's valuable or even possible - we don't export the validation data, we just export the local and server info, and the validator in the version of Firefox which reads the export is the version used to perform the validation.

It might be useful to include the validator info in the UI so screenshots like the above make it more obvious, but we probably want to discourage people from using screenshots anyway.

@kitcambridge, what do you think?

thomcc commented 7 years ago

I think there's a good argument that we should export validation data, since the validator isn't 100% accurate when run on non-local data, e.g. it does make some places calls inside it.