Linguee "Search" command makes a Google search

[alexandra-martin]

Prerequisites:

Mic permissions are enabled. "Allow" or "Don't Allow" button from “Allow Firefox Voice to Collect Voice Transcriptions” pop-up is clicked.

STR:

1. Use the shortcut or click on the mic icon from the browser toolbar.
2. Say or write a Linguee "Search" command, e.g. "Search voice on Linguee", "Look up voice on Linguee", "Look up Linguee for voice".

Expected result:

Linguee opens in a new tab with the correct result.

Actual result:

Google opens in a new tab and makes a search for "voice on Linguee"\ "Linguee for voice".

Notes:

Reproduced on Mac 10.14 and Win10x64 with Firefox Nightly 77.0a1 (2020-04-22).

[dave-ok]

@alexandra-martin Linguee had not been implemented yet. I have created a PR towards this

[alexandra-martin]

@dave-ok Oh ok. I thought it was, since it appears in the "Lexicon" page in the supported sites. Thank you for making the PR.

[annlinros]

I have also made a PR for this way back🙈

[dave-ok]

Yes @annlinros I saw your PR. Unfortunately, you worked on the suggested followup but missed the original issue. I guess that was why the PR had not been merged yet. I realized this when trying to fix the bug. Maybe you could try to create a separate issue for the followup and make a PR towards that

[annlinros]

no @dave-ok my PR also addressed the bang search for linguee, if you check the changed files you will find that..And the search works actually.

[dave-ok]

@annlinros Oh! Sorry I missed that. Hopefully your PR will get merged first and the one I raised will be redundant

[annlinros]

No worries!! If you would like, you could make another PR for the other intent , say [query] on linguee. My event listeners are not working properly and that functionality is not complete. I would love to see your solution.

[dave-ok]

@annlinros Cool. Maybe I will