search

mozilla-extensions / firefox-voice

Firefox Voice is an experiment in a voice-controlled web user agent
Mozilla Public License 2.0
286 stars 122 forks source link

Close lightbox #998

Open awallin opened 4 years ago

awallin commented 4 years ago

When a lightbox overlays the active page saying 'close' should close the lightbox revealing the primary page content.

noi5e commented 4 years ago

Hey @awallin I'm an Outreachy intern applicant... Trying to figure out if this issue is maybe a good first issue for me.

Can you list some ideas for how you'd go about implementing this, or any packages you would use?

I guess to start with, I'd need a way to find out if a given <div> is a lightbox or not. Would appreciate any insight

awallin commented 4 years ago

@ianb Can you provide any guidance?

ianb commented 4 years ago

@noi5e I assigned another bug to you, probably you should try to fix one or the other first. This one is less clear than the other, so it would be best to work the other one first.

Honestly I don't know the best way to figure out if something is a lightbox. The best first contribution might be to find several lightboxes and try to identify the close button and how to detect the lightbox, and see if there's something worth generalizing. For something like the contribution might ultimately be a well-researched comment rather than a PR ready to merge.

noi5e commented 4 years ago

@ianb Thanks! Yeah, happy to work on the other one for now. thanks for the comment