GuM is not working with Secure Proxy off

mozilla-extensions / secure-proxy

Firefox Private Network Web Extension

Mozilla Public License 2.0

140 stars 33 forks source link

GuM is not working with Secure Proxy off #353

Closed SoftVision-LorandJanos closed 5 years ago

SoftVision-LorandJanos commented 5 years ago

Affected versions:

All Firefox versions.

Affected Platforms:

All Windows

Prerequisites:

Secure Proxy is installed and disabled.

Steps to reproduce

Go to GuM Test Page.
Click on "Audio & Video".

Expected result:

A prompt for permissions to access the camera and microphone on your machine is displayed.

Actual result:

The prompt is not displayed.
The "NotAllowedError: The request is not allowed by the user agent or the platform in the current context." message is displayed.

Screenshot (156)

bakulf commented 5 years ago

This is the wanted behavior for the beta version. We should be able to send webRTC network requests via proxy for the paid version. @jonathanKingston is there anything we can do here? I don't think so.

jonathanKingston commented 5 years ago

@bakulf I misread this bug too, I think @SoftVision-LorandJanos is suggesting as the proxy is off we have overriden the properties and caused a bug when the network status is off.

@SoftVision-LorandJanos I however couldn't reproduce this just using the "audio" button, could you confirm if it happens there (I don't have a web cam so that dual button always fails).

SoftVision-LorandJanos commented 5 years ago

@jonathanKingston yes, just using the "audio" button works here as well.

jonathanKingston commented 5 years ago

@SoftVision-LorandJanos I checked on the mac I am testing with and can't reproduce this with the latest code using the dual button.

SoftVision-LorandJanos commented 5 years ago

@jonathanKingston Yes, sorry for the confusion created here. I've initially tested with SP on and wanted to file an issue for that but as baku mentioned it is the desired behavior for beta.

And yes I was referring to the fact that WebRTC is still blocked even with SP off but I forgot to remove Mac and Linux from the platforms as these are not affected. Sorry for that.

Modified the bug submission to reflect this.

jonathanKingston commented 5 years ago

Hmm the code shouldn't be any differently on Windows unless we have native differences in Firefox. The only thing I can see from your screenshot is that you are on the http page which should always deny the use of these APIs.

I don't have Windows setup at the moment to check if this is the case. Could you double check if Windows over https still behaves with not showing the prompt?

nils-ohlmeier commented 5 years ago

@SoftVision-LorandJanos in a recent version of Firefox we switched to only allow gUM from HTTPS origins.

@bakulf gUM should work no matter if the SP is on or off. gUM is independent of PeerConnection. There are probably not that many pages which use gUM without PeerConnection. But I don't see why we would have to block gUM when SP is on.

SoftVision-LorandJanos commented 5 years ago

@jonathanKingston today we checked again, same way as yesterday, new profiles on nightly, beta and release versions on my and on @bsurd's computer and it doesn't reproduce today. Yesterday however the error was consistent so we will investigate a bit more to see if there was any detail that might have caused it.

SoftVision-LorandJanos commented 5 years ago

When accessing the GuM page this modal is displayed. From our understanding this shouldn't happen.
The page now works with Secure Proxy off.

bakulf commented 5 years ago

Fixed in v0.9

bsurd commented 5 years ago

Verified in v11 and the issue is no longer reproducible.