search

mozilla-frontend-infra / firefox-health-dashboard

https://firefox-health-dashboard.netlify.com
Mozilla Public License 2.0
26 stars 68 forks source link

charts locked to time domains #642

Closed vshkr99 closed 4 years ago

vshkr99 commented 4 years ago

Here I have resolve issue #466 . The charts have been locked to time domain by passing the labels as prop to the Chart component. Data points get distributed within the time range passed.

klahnakoski commented 4 years ago

Rather than generating the labels, which will depend on the size of the range, and depend on if the min and max are even provided: Ensure ChartJS receives the min/max; it can handle the variety of edge cases.

vshkr99 commented 4 years ago

Okay that's a nice suggestion. Will make the changes soon.