mozilla-frontend-infra / firefox-health-dashboard

https://firefox-health-dashboard.netlify.com
Mozilla Public License 2.0
26 stars 68 forks source link

simplify expression #683

Closed klahnakoski closed 3 years ago

klahnakoski commented 4 years ago

This piece of code performs markup on the performance metadata

fission: Boolean(meta.extra_options) && meta.extra_options.includes('fission')

In theory we should be able to remove it and replace

{ eq: { fission: false } }

with

 {eq: {extraOptions: "fission"}}

or

{"in": [{"literal":"fission"}, "extraOptions"]}

...which should be effectively the same